Adding responseURL to jqXHR #4405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmadhav
changed the title
mgol
reviewed
May 19, 2019
mgol
requested changes
Jul 18, 2019
csmadhav
force-pushed
the
4339-adding-responseurl-field-jqxhr
branch
from
467cea1
to
25cee2d
Compare
|
sorry for updating this late. |
mgol
reviewed
Jan 9, 2020
| xhr.statusText, | ||
|
|
||
| // For XHR2 non-text, let the caller handle it (gh-2498) | ||
| xhr.statusText, // For XHR2 non-text, let the caller handle it (gh-2498) |
There was a problem hiding this comment.
This comment shouldn't have been moved, please move it back below.
| errorURL = "http://example.invalid", | ||
| redirectAndSuccessURL = url( "mock.php?action=responseURL&url=" + encodeURIComponent( successURL ) ), | ||
| redirectAndErrorURL = url( "mock.php?action=responseURL&url=" + encodeURIComponent( errorURL ) ), | ||
| jsonpURL = baseURL + "mock.php?action=jsonp&callback=?", |
There was a problem hiding this comment.
Is there any reason why this uses baseURL directly instead of the url function?
| @@ -711,7 +711,7 @@ jQuery.extend( { | |||
| } | |||
|
|
|||
| // Callback for when everything is done | |||
| function done( status, nativeStatusText, responses, headers ) { | |||
| function done( status, nativeStatusText, responses, headers, responseURL ) { | |||
There was a problem hiding this comment.
Unfortunately, this function signature is public API as that's the shape of completeCallback as described here: https://api.jquery.com/jQuery.ajaxTransport/
This is a new parameter at the end so it's not a breaking change. However, we need to think if this is a good API as 5 unnamed parameters is quite a lot.
(from my comment from #4405 (comment))
There was a problem hiding this comment.
FYI: I opened #4634 to make passing responseURL possible without adding more positional parameters to this function.
|
Adding the "Needs review" label back to discuss #4405 (comment) |
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Mar 1, 2020
Apart from the existing API:
```js
function( status, statusText, responses, headers ) {}
```
a new API is now available:
```js
function( { status, statusText, responses, headers } ) {}
```
This makes it possible to add new parameters in the future without relying on
their order among parameters and being able to provide them selectively.
Ref jquerygh-4405
4 tasks
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Dec 8, 2020
Apart from the existing API:
```js
function( status, statusText, responses, headers ) {}
```
a new API is now available:
```js
function( { status, statusText, responses, headers } ) {}
```
This makes it possible to add new parameters in the future without relying on
their order among parameters and being able to provide them selectively.
Ref jquerygh-4405
|
Closing & re-opening the PR to trigger the EasyCLA check... |
|
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jul 10, 2023
Apart from the existing API:
```js
function( status, statusText, responses, headers ) {}
```
a new API is now available:
```js
function( { status, statusText, responses, headers } ) {}
```
This makes it possible to add new parameters in the future without relying on
their order among parameters and being able to provide them selectively.
Ref jquerygh-4405
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 21, 2023
Apart from the existing API:
```js
function( status, statusText, responses, headers ) {}
```
a new API is now available:
```js
function( { status, statusText, responses, headers } ) {}
```
This makes it possible to add new parameters in the future without relying on
their order among parameters and being able to provide them selectively.
Ref jquerygh-4405
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Nov 20, 2023
Apart from the existing API:
```js
function( status, statusText, responses, headers ) {}
```
a new API is now available:
```js
function( { status, statusText, responses, headers } ) {}
```
This makes it possible to add new parameters in the future without relying on
their order among parameters and being able to provide them selectively.
Ref jquerygh-4405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #4339
I've taken some references from #1615 (which needed to be resurrected)
original PR was from @xKerman
Since recently support for some browsers was dropped in jquery respective changed were also added.
Please ignore the previous PR (closed already)
Checklist