Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization of Install Logic #154

Merged
merged 2 commits into from
May 29, 2024

Conversation

Leon0402
Copy link
Contributor

@Leon0402 Leon0402 commented Mar 8, 2023

This PR aims to not only install the library & inlcude headers, but also the target definition itself including required dependencies.

This allows Consumer Projects to do the following:

find_package(curlpp)

which will use findPackage in the recommended config mode and also ensures that dependencies such as curl are available.

or

add_subdirectory(curlpp) # git submodule, FetchContent, CPM, ...

And then in any case the target can be linked the same way. This will propagate all neded headers, libraries, dependencies, ...:

target_link_libraries(my_target PUBLIC curlpp::curlpp)

@Leon0402
Copy link
Contributor Author

@jpbarrette Could you please take a look. We are using my fork for one year now and would like to switch back to the master branch here.

@jpbarrette jpbarrette merged commit 511241a into jpbarrette:master May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants