Fix potential unhandled rejections in StrategyHandler.doneWaiting

doneWaiting throws on the first rejected promise that it encounters.  This means that subsequent rejected promises may result in unhandled rejection errors.

Fixes GoogleChrome#3171

packages/workbox-core/src/_private/allSettled.ts

@@ -0,0 +1,40 @@
+export interface PromiseResolution<T> {
+ status: 'fulfilled';
+ value: T;
+}
+
+export interface PromiseRejection {
+ status: 'rejected';
+ reason: unknown;
+}
+
+export type PromiseResult<T> = PromiseResolution<T> | PromiseRejection;
+
+/**
+ * Promise.allSettled polyfill based on
+ *
+ * https://github.com/es-shims/Promise.allSettled/blob/main/implementation.js
+ *
+ * which is (c) 2019 Jordan Harband and used under the terms of the MIT license.
+ */
+export function allSettled<T>(
+ iterable: Iterable<Promise<T>>,
+): Promise<PromiseResult<T>[]> {
+ const values = Array.from(iterable);
+ return Promise.all(
+ values.map(function (item) {
+ const onFulfill = function (value: T) {
+ return {status: 'fulfilled' as const, value: value};
+ };
+ const onReject = function (reason: unknown) {
+ return {status: 'rejected' as const, reason: reason};
+ };
+ const itemPromise = Promise.resolve(item);
+ try {
+ return itemPromise.then(onFulfill, onReject);
+ } catch (e) {
+ return Promise.reject(e);
+ }
+ }),
+ );
+}

packages/workbox-strategies/src/StrategyHandler.ts

@@ -6,6 +6,10 @@
  https://opensource.org/licenses/MIT.
 */
 
+import {
+ allSettled,
+ PromiseRejection,
+} from 'workbox-core/_private/allSettled.js';
 import {assert} from 'workbox-core/_private/assert.js';
 import {cacheMatchIgnoreParams} from 'workbox-core/_private/cacheMatchIgnoreParams.js';
 import {Deferred} from 'workbox-core/_private/Deferred.js';
@@ -560,9 +564,13 @@ class StrategyHandler {
  * prior to your work completing.
  */
  async doneWaiting(): Promise<void> {
- let promise;
- while ((promise = this._extendLifetimePromises.shift())) {
- await promise;
+ while (this._extendLifetimePromises.length) {
+ const promises = this._extendLifetimePromises.splice(0);
+ const result = await allSettled(promises);
+ const firstRejection = result.find((i) => i.status === 'rejected');
+ if (firstRejection) {
+ throw (firstRejection as PromiseRejection).reason;
+ }
  }
  }