Initial Docker and Gitpod support

[MatteoGheza]

@hrueger #87 (comment) if you want to try this, I suggest you to go to https://gitpod.io/#https://github.com/josephdadams/TallyArbiter/pull/103 and login with Github

[hrueger]

Looks good to me 👍
Maybe you can add a GitHub Action Workflow which runs on pushes and builds the image and if it is a tag, publishes the image to Docker Hub?

[MatteoGheza]

Sorry, I didn't read the comment (I was trying to setup a simple e2e testing system using cypress.io, and I had some problems with a library used for intercepting WebSockets, so I had to fork it).
Tomorrow I'll try.
Thanks for the feedback.

[josephdadams]

Also add docker and gitpod instructions somewhere in the readme, docusaurus, etc. so people can know about it :)

[MatteoGheza]

GitHub Action Workflow it's working.
https://hub.docker.com/r/matteogheza/tallyarbitertestimage/tags?page=1&ordering=last_updated
https://github.com/MatteoGheza/TallyArbiter/runs/3027417377?check_suite_focus=true

TODO before merging:

• Replace matteogheza/tallyarbitertestimage (line 41 in .github/workflows/build.yml)
• Add DOCKERHUB_USERNAME and DOCKERHUB_TOKEN in repository actions secrets
• Docker and Gitpod instructions somewhere in the documentation
• Build multi-arch Docker image (only during release)
• Fix GitHub Actions Workflow (Yaml syntax error, @hrueger help wanted 😅)

[MatteoGheza]

I started adding references to Docker and Gitpod, but I'm not good at writing documentation 😂

[hrueger]

@MatteoGheza

Fix GitHub Actions Workflow (Yaml syntax error, @hrueger help wanted 😅)

If I remove all if: !(startsWith(github.ref, 'refs/tags/v')), the yaml becomes valid. Maybe we need to escape the ! somehow? I'm not that familiar with yaml.

[hrueger]

According to https://github.community/t/expression-syntax-for-not-startswith/17040/4 we need to put the expression in double quotes or as stated in https://github.community/t/expression-syntax-for-not-startswith/17040/3 the following should work, too:

if: startsWith(github.ref, 'refs/tags/v') != true

I'd personally prefer double quotes.

[MatteoGheza]

Now it's working!

[josephdadams]

I added the repo secrets, modified the yml for the correct docker path, and updated the documentation to include that path as well.

[josephdadams]

@MatteoGheza ready to merge?

[MatteoGheza]

I found a small TODO in documentation.
Sorry for the late reply.

[MatteoGheza]

Any updates? Has anyone tried this?
Is this ready to be merged?

[hrueger]

Works for me 👍

[josephdadams]

Merged. If anyone has an issue we can troubleshoot. 😂