This repository has been archived by the owner on Jun 16, 2024. It is now read-only.
Use OptionSetValue.Value for comparison with optionset group by #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Phil for this PR, I'm in the middle of an upgrade to 2.x using .net core so I'm tagging all these PRs to be merged once that one is published. I'm busy for a while with these so for now it might be better to push your own fork into a private nuget server for consumption until 2.x is released. Then I'll go through the PRs one be one to merge them into v2.x FYI, @BetimBeja |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #482