Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for zsh #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

grzesuav
Copy link

Checklist

  1. Adresses Issue: Make kubectl-prompt suitable for use with zsh #9
  2. Quick summary of changes
    POC of new helper function definition
  3. Changes are GNU/BSD Compatable:yes
  4. Changes are applicable to the wider community: yes
  5. Request help with testing if needed: yes

@grzesuav
Copy link
Author

This is POC for now. I am not bash/zsh programmer so I am not aware of consequences. I tested this function locally on bash and zsh and it was working for me, but I have too limited knowledge to see bigger context

@grzesuav
Copy link
Author

please do not merge

@Jefferson-Faseler
Copy link

@grzesuav Hey! I branched off of you and opened another PR so you wouldn't have to play middleman and we go through two PR's to get it here. You can find the PR here:
#27

Of course left your fingerprints on the commits, lmk if you have any questions.

@grzesuav
Copy link
Author

no problem, good that you had time to carry this work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants