Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2][Events] Use event classes for Content plugins #43426

Open
wants to merge 13 commits into
base: 5.2-dev
Choose a base branch
from
Open

[5.2][Events] Use event classes for Content plugins #43426

wants to merge 13 commits into from

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented May 4, 2024 •
edited

Summary of Changes

Update content plugins to use SubscriberInterface and an event classes.

Testing Instructions

Check following content plugins should work as before:

confirmconsent
contact
emailcloak
fields
finder
joomla
loadmodule
pagebreak
pagenavigation
vote

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

References:

@Fedik Fedik added the Feature label May 4, 2024
@Fedik Fedik changed the title [5.2][Events] Use event classes for content plugins [5.2][Events] Use event classes for Content plugins May 4, 2024
@Fedik

This comment was marked as outdated.

Sign in to view
@Fedik Fedik marked this pull request as draft May 5, 2024 07:43
@richard67
Copy link
Member

Drone failure is not related to this PR.

Hackwar and others added 2 commits May 29, 2024 19:31
@Hackwar
[5.2] Cleanup of return types for phpstan (joomla#43350)
dfb572d 
* Cleanup of return types

* Return nothing instead of an empty string

* Update OverridesModel.php
@Fedik
Merge branch '5.2-dev' into plg-event-content
392c8bd
@Fedik Fedik marked this pull request as ready for review June 2, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature PR-5.2-dev Unit/System Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fedik @richard67 @joomla-cms-bot @Hackwar