Fix #3425 jooby-pac4j module: set config for ProfileManager in Pac4jC… #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger in Pac4jCurrentUser
jknack
requested changes
May 18, 2024
| @@ -581,7 +581,7 @@ public void install(@NonNull Jooby application) throws Exception { | |||
| }); | |||
| } | |||
| /** Set current user provider */ | |||
| application.setCurrentUser(new Pac4jCurrentUser()); | |||
| application.setCurrentUser(new Pac4jCurrentUser(pac4j)); | |||
There was a problem hiding this comment.
Let's make the pac4j configuration accesible by adding to registry:
application.getServices().put(Config.class, pac4j);
There was a problem hiding this comment.
OK. I added the configuration to the registry at the end of the install method because above, the configuration can be changed
jknack
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix renewing the Profile in the jooby-pac4j module by setting the configuration for the ProfileManager in Pac4jCurrentUser.