Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jknack
AvajeInjectModule seems doesn't work as expected, at least for me.
With a very basic example (reproduced in test c9c81fd) Jooby inner services injection fails with class cast exception, for example
JsonMapper
:I assume this is due to the fact that services already wrapped into lambda in
singletone()
jooby/jooby/src/main/java/io/jooby/internal/ServiceRegistryImpl.java
Line 61 in 03bb587
Hence, the default binding need to be changed to
beanScope.provideDefault(key.getType(), e.getValue()::get);
Also,
Config
binding was removed as it is already in service registry