Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/openapi nonnull issue #3413

Merged
merged 5 commits into from
May 12, 2024

Conversation

kliushnichenko
Copy link
Contributor

@kliushnichenko kliushnichenko commented Apr 18, 2024

Closes #3412
For some reason method.invisibleParameterAnnotations contains null entries. It looks like ASM issue? I'm not good at it. But a dumb fix is here.

@jknack jknack added this to the 3.1.0 milestone May 6, 2024
@jknack jknack added the openapi label May 6, 2024
@jknack
Copy link
Member

jknack commented May 6, 2024

Hi @kliushnichenko can you rebase?

dependabot bot and others added 3 commits May 6, 2024 13:50
Bumps the dependencies group with 16 updates:

| Package | From | To |
| --- | --- | --- |
| [io.netty:netty-bom](https://github.com/netty/netty) | `4.1.108.Final` | `4.1.109.Final` |
| [io.netty:netty-common](https://github.com/netty/netty) | `4.1.108.Final` | `4.1.109.Final` |
| [io.netty:netty-buffer](https://github.com/netty/netty) | `4.1.108.Final` | `4.1.109.Final` |
| [io.netty:netty-handler](https://github.com/netty/netty) | `4.1.108.Final` | `4.1.109.Final` |
| [io.netty:netty-transport](https://github.com/netty/netty) | `4.1.108.Final` | `4.1.109.Final` |
| [io.netty:netty-transport-native-epoll](https://github.com/netty/netty) | `4.1.108.Final` | `4.1.109.Final` |
| [io.netty:netty-codec-http](https://github.com/netty/netty) | `4.1.108.Final` | `4.1.109.Final` |
| [io.netty:netty-codec-http2](https://github.com/netty/netty) | `4.1.108.Final` | `4.1.109.Final` |
| [io.netty:netty-transport-native-kqueue](https://github.com/netty/netty) | `4.1.108.Final` | `4.1.109.Final` |
| [com.amazonaws:aws-java-sdk-bom](https://github.com/aws/aws-sdk-java) | `1.12.701` | `1.12.705` |
| [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) | `1.5.5` | `1.5.6` |
| [com.graphql-java:graphql-java](https://github.com/graphql-java/graphql-java) | `21.5` | `22.0` |
| [io.undertow:undertow-core](https://github.com/undertow-io/undertow) | `2.3.12.Final` | `2.3.13.Final` |
| [com.github.vladimir-bukhtoyarov:bucket4j-core](https://github.com/vladimir-bukhtoyarov/bucket4j) | `7.6.1` | `8.0.1` |
| [org.apache.maven.plugins:maven-jar-plugin](https://github.com/apache/maven-jar-plugin) | `3.4.0` | `3.4.1` |
| [org.apache.maven.plugins:maven-gpg-plugin](https://github.com/apache/maven-gpg-plugin) | `3.2.3` | `3.2.4` |


Updates `io.netty:netty-bom` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-common` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-buffer` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-handler` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-transport` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-transport-native-epoll` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-codec-http` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-codec-http2` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-transport-native-kqueue` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `com.amazonaws:aws-java-sdk-bom` from 1.12.701 to 1.12.705
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-java@1.12.701...1.12.705)

Updates `ch.qos.logback:logback-classic` from 1.5.5 to 1.5.6
- [Commits](qos-ch/logback@v_1.5.5...v_1.5.6)

Updates `com.graphql-java:graphql-java` from 21.5 to 22.0
- [Release notes](https://github.com/graphql-java/graphql-java/releases)
- [Commits](graphql-java/graphql-java@v21.5...v22.0)

Updates `io.undertow:undertow-core` from 2.3.12.Final to 2.3.13.Final
- [Commits](undertow-io/undertow@2.3.12.Final...2.3.13.Final)

Updates `io.netty:netty-common` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-buffer` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-handler` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-transport` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-transport-native-epoll` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-codec-http` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `com.github.vladimir-bukhtoyarov:bucket4j-core` from 7.6.1 to 8.0.1
- [Release notes](https://github.com/vladimir-bukhtoyarov/bucket4j/releases)
- [Commits](https://github.com/vladimir-bukhtoyarov/bucket4j/commits/8.0.1)

Updates `org.apache.maven.plugins:maven-jar-plugin` from 3.4.0 to 3.4.1
- [Release notes](https://github.com/apache/maven-jar-plugin/releases)
- [Commits](apache/maven-jar-plugin@maven-jar-plugin-3.4.0...maven-jar-plugin-3.4.1)

Updates `org.apache.maven.plugins:maven-gpg-plugin` from 3.2.3 to 3.2.4
- [Release notes](https://github.com/apache/maven-gpg-plugin/releases)
- [Commits](apache/maven-gpg-plugin@maven-gpg-plugin-3.2.3...maven-gpg-plugin-3.2.4)

Updates `io.netty:netty-codec-http2` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

Updates `io.netty:netty-transport-native-kqueue` from 4.1.108.Final to 4.1.109.Final
- [Commits](netty/netty@netty-4.1.108.Final...netty-4.1.109.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-buffer
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-handler
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-transport
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-transport-native-epoll
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-codec-http
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-codec-http2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-transport-native-kqueue
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: com.amazonaws:aws-java-sdk-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: ch.qos.logback:logback-classic
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: com.graphql-java:graphql-java
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: dependencies
- dependency-name: io.undertow:undertow-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-buffer
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-handler
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-transport
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-transport-native-epoll
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-codec-http
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: com.github.vladimir-bukhtoyarov:bucket4j-core
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: dependencies
- dependency-name: org.apache.maven.plugins:maven-jar-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: org.apache.maven.plugins:maven-gpg-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-codec-http2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: io.netty:netty-transport-native-kqueue
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
# Conflicts:
#	modules/jooby-openapi/src/main/java/io/jooby/internal/openapi/AnnotationParser.java
#	modules/jooby-openapi/src/test/java/io/jooby/openapi/OpenAPIYamlTest.java
#	pom.xml
@kliushnichenko
Copy link
Contributor Author

should be ok now

@jknack jknack merged commit 431ba8c into jooby-project:3.x May 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openapi] @QueryParam witn @NonNull annotation breaks openapi parser
2 participants