Add Rocker style pre-encoding for JStachio #2921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jknack I have updated the JStachio module so that it can take advantage of pre-encoding (the static parts of the template are generated as bytes[] in advance).
The reason I did this is that in the techempower benchmarks Rocker performed better than JStachio's naive
String.getBytes()
.I also have added threadlocal buffering and removed setting charset.
Setting the charset was a bad idea anyway as JStachio unlike others cannot always re-read the template from the filesystem furthermore escaping is naturally tied to charset.
I noticed that Rocker just assumes MediaType.html (and thus UTF-8) so I have done likewise.
I just released jstachio 0.17.0 but it will take an hour or so before central shows it.