Correctly identify Ellipsis as 3 dots #367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 2 dots no longer turned into Ellipsis
|
Hey @jonschlinkert not sure how to get someone to look at a PR so just giving you a ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the best of my knowledge and exploration, Ellipsis consists of 3 dots (...) not 2. This bug is causing issues where consumers are trying to read format examples and getting it wrong in a downstream tool (swagger-ui) that consumes this library. Because an Ellipsis is shown, they try and send us a format including 3 dots instead of the required 2. Rather than loosing all of the other auto-formatting turning off typography to work around a bug, I'd rather see it fixed as the source.
Yes, this would be a breaking change for existing users, but I understand that common-mark does it right, and that the correct format to get an ellipsis is to use 3 dots, anyway. I believe this implementation using two dots therefore to be a legit bug :)
working example in commonmark