Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete Support #10

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

drgrib
Copy link

@drgrib drgrib commented Nov 18, 2023

I've never added autocomplete to a VS Code extension before, so I'm not sure what all of this is necessary. I just have a local modified copy of your extension that I added this code to and it works for me after I run npm install in the main directory, reload window, and press F5.

Please feel free to edit or suggest edits as you see fit to clean it up.

@drgrib
Copy link
Author

drgrib commented Nov 18, 2023

This is the repo I used as an example, for reference:

https://github.com/microsoft/vscode-extension-samples/tree/main/completions-sample

@drgrib
Copy link
Author

drgrib commented Nov 18, 2023

I had tab autocomplete for arguments but it was honestly slower than just pressing space so now keywords with arguments just leave a space at the end of the autocomplete so you can begin typing the arguments. The lines can still be used as a reference for syntax before autocompleting, though. Change documented in 05ca618.

@jonahsnider
Copy link
Owner

Thank you so much for the contribution! I'm not really doing a good job maintaining this extension anymore. Would it be alright if you published your fork as a new extension on the VS Code marketplace? I'd be happy to mark mine as deprecated & yours as the replacement.

@drgrib
Copy link
Author

drgrib commented Dec 2, 2023

Haha. No worries. I haven't invested any time testing this to even make sure it works on other people's systems. I just wanted to share it in case it works. I'm really just using it for my own personal playthrough.

Feel free to close the PR if you like. Or you could leave it open in case someone new appears and is willing to test it because they want autocomplete for the game. If they test it and it works, I'd be happy to publish it as a new extension from my own fork as you requested.

@jonahsnider
Copy link
Owner

Happy to leave the PR open in case anyone else stumbles onto this repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants