Use comprehension in it_IT address provider to populate cities #2043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This PR uses a single set-comprehension to populate the
cities
list for it_IT locale.What was wrong
The previous implementation used a series of nested for-loops to build up a unique list of cities in the it_IT locale using a strange inline at line 10 to avoid using a normal IF statement.
faker/faker/providers/address/it_IT/__init__.py
Lines 6 to 11 in 2069bd3
While profiling the code in which I use this provider I found out it was taking a long time to load.
How this fixes it
Using a set-comprehension and then turning that into a list takes advantages of built-in features of set and the usage of
.items()
for iterating over a dict provide better performances.Local benchmark tests with timeit shows the latter is at least 100x faster.