Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Code Review – From Good to Great #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sizovs
Copy link

@sizovs sizovs commented Jul 28, 2020

No description provided.

@@ -27,6 +27,7 @@ Code review is the systematic examination (sometimes referred to as peer review)

## Articles

- [Code Review – From Good to Great](https://sizovs.net/2020/07/19/the-code-review/) People rarely talk about it, but in many companies, code review makes developers feel like sh%t. This is a practical guide on how to create a code review process that developers love.
- [8 Tips for Great Code Reviews](https://kellysutton.com/2018/10/08/8-tips-for-great-code-reviews.html) A few basic rules for a better code review process.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was really cool!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works !

@@ -27,6 +27,7 @@ Code review is the systematic examination (sometimes referred to as peer review)

## Articles

- [Code Review – From Good to Great](https://sizovs.net/2020/07/19/the-code-review/) People rarely talk about it, but in many companies, code review makes developers feel like sh%t. This is a practical guide on how to create a code review process that developers love.
- [8 Tips for Great Code Reviews](https://kellysutton.com/2018/10/08/8-tips-for-great-code-reviews.html) A few basic rules for a better code review process.
- [A Zen Manifesto for Effective Code Reviews](https://medium.freecodecamp.org/a-zen-manifesto-for-effective-code-reviews-e30b5c95204a) Practical tips for the submitter and the reviewer to make effective code reviews.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test...

Copy link

@TheFenrisLycaon TheFenrisLycaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests Passed !

@sizovs
Copy link
Author

sizovs commented Nov 22, 2021

Hey @joho

Will I get my PR approved someday? 🙏

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants