-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly get_full_info for songs and albums #181
base: master
Are you sure you want to change the base?
Conversation
Previously, it was fetched only when the song didn't have an id (?)
Hi. Thanks for contributing to LyricsGenius. The |
For the
or:
What do you think, @johnwmillr? |
Another solution might be to use |
…ten in both search_song and search_album
Your PR is about ready. Just apply the change in the last conversation and remove the changes to |
This reverts commit bb948b1
Please squash this commit! :)
@allerter I've done as you asked. I checked, and confirm that Thanks for your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I think it's good to go.
@johnwmillr, could you please review and merge this? |
Hi Dear @allerter
I used the liyricsgenius package. But I don't know how to integrate Genius authentication method into Code. If anyone knows, please help!!! |
Previously, the full song info wasn't fetched, as
song_id
never wasNone
, and the checkif song_id is None
stopped the retrieval from executing.I corrected that line, and added the new fields to the
Song
type; some of them should probably have a corresponding type too, but I don't currently have time to implement them right now.