Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task.py: try to find json in task output using regex #491

Merged
merged 2 commits into from May 2, 2024

Conversation

ftoppi
Copy link
Contributor

@ftoppi ftoppi commented Apr 22, 2024

Sometimes the model replies with a valid and additional text, let's try to extract and validate it first. It's cheaper than calling LLM for that.

I think we could even replace the code above with only this one, the regex will match both.

ftoppi and others added 2 commits April 22, 2024 23:17
Sometimes the model replies with a valid and additional text, let's try to extract and validate it first. It's cheaper than calling LLM for that.
Copy link
Owner

@joaomdmoura joaomdmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, moved a few things around slightly but I think this is a great idea!

@joaomdmoura joaomdmoura merged commit 0a35868 into joaomdmoura:main May 2, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants