Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New question categories #2

Open
wants to merge 13 commits into
base: max-players
Choose a base branch
from
Open

New question categories #2

wants to merge 13 commits into from

Commits on Dec 19, 2022

  1. Add a failing test for extensible categories

    @joanna-liana
    joanna-liana committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    daeadb4 View commit details
    Browse the repository at this point in the history

  2. Implement extensible question categories

    @joanna-liana
    joanna-liana committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    169043c View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Fix type in tests

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    98526da View commit details
    Browse the repository at this point in the history

  2. Improve Questions test to focus on actual content

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    9c29ef7 View commit details
    Browse the repository at this point in the history

  3. Implement extensible question categories

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    8207a5d View commit details
    Browse the repository at this point in the history

  4. Move logging question from Questions to Game

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    0487214 View commit details
    Browse the repository at this point in the history

  5. Refactor asking question in Game

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    62fec85 View commit details
    Browse the repository at this point in the history

  6. Shift tested entrypoint from deprecated askOne to new chooseOne

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    6c6778d View commit details
    Browse the repository at this point in the history

  7. Store questions in test outside of logger spy

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    e47153d View commit details
    Browse the repository at this point in the history

  8. Remove logger from Questions test

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    ad4da62 View commit details
    Browse the repository at this point in the history

  9. Remove redundant dependency on logger from Questions

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    9e0d8ac View commit details
    Browse the repository at this point in the history

  10. Remove unused askOne from Questions

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    ba772a7 View commit details
    Browse the repository at this point in the history

  11. Group public Questions API methods together

    @joanna-liana
    joanna-liana committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    2282457 View commit details
    Browse the repository at this point in the history