Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: fix Github to GitHub #882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morihaya
Copy link

I have corrected 'Github' to 'GitHub' as per Pull Request #867.

I have corrected 'Github' to 'GitHub' as per Pull Request jlevy#867.
@@ -94,7 +94,7 @@ They have kindly agreed to review and help update future contributions for the t
* [Ashhar Hasan (hashhar)](https://github.com/hashhar) — [0+](https://github.com/jlevy/the-art-of-command-line/commits?author=hashhar)/[1+](https://github.com/jlevy/the-art-of-command-line/issues?q=author%3Ahashhar)
* [Beau Hastings (hastinbe)](https://github.com/hastinbe) — [1+](https://github.com/jlevy/the-art-of-command-line/commits?author=hastinbe)/[4+](https://github.com/jlevy/the-art-of-command-line/issues?q=author%3Ahastinbe)
* [Iliana Panagopoulou (hpanago)](https://github.com/hpanago) — [3+](https://github.com/jlevy/the-art-of-command-line/commits?author=hpanago)/[2+](https://github.com/jlevy/the-art-of-command-line/issues?q=author%3Ahpanago)
* [Space exploration enthusiast (Hunter-Github)](https://github.com/Hunter-Github) — [0+](https://github.com/jlevy/the-art-of-command-line/commits?author=Hunter-Github)/[5+](https://github.com/jlevy/the-art-of-command-line/issues?q=author%3AHunter-Github)
* [Space exploration enthusiast (Hunter-GitHub)](https://github.com/Hunter-GitHub) — [0+](https://github.com/jlevy/the-art-of-command-line/commits?author=Hunter-GitHub)/[5+](https://github.com/jlevy/the-art-of-command-line/issues?q=author%3AHunter-GitHub)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to change GitHub cases in URL

I noticed this line, but I think the problem is more general.

If the author name was updated because case was not reflecting the path URI. I think you should mention it in your commit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean here is the current name of author

https://github.com/Hunter-Github

Not https://github.com/Hunter-GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants