Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a modification to the catalog-items 2022 data, Pagination and Refinements must be nullable. #741

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

KhorneHoly
Copy link

Fix for this issue: #740

@jlevers
Copy link
Owner

jlevers commented Jun 25, 2024

Looks good, thanks! Only comment is that it looks like the indentation in ItemSearchResults.php got switched from spaces to tabs. I think running composer lint will fix that, but if it doesn't, just switch the indentation from tabs to 4 spaces. I just like to keep things consistent :)

@KhorneHoly
Copy link
Author

Looks good, thanks! Only comment is that it looks like the indentation in ItemSearchResults.php got switched from spaces to tabs. I think running composer lint will fix that, but if it doesn't, just switch the indentation from tabs to 4 spaces. I just like to keep things consistent :)

I stated some issues with the generation in my last comment of the Issue. I've now read the contributing again. There's stated that the config.json would provide some basic configuration for the generation, but there's now config.json to be found within the project. Maybe that's why the generation differs?

composer lint fixed it though.

@jlevers
Copy link
Owner

jlevers commented Jun 26, 2024

Ah, that's a documentation error – the file is called generator-config.json in this repo. I just fixed that in the CONTRIBUTING.md doc. Thanks for catching that.

@jlevers jlevers merged commit 2fff6c1 into jlevers:main Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants