Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check multiple possible datetime formats before throwing an exception #737

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

KhorneHoly
Copy link

Fix for this issue: #735

oliver added 2 commits June 20, 2024 17:24
… be used by Amazon.

Throw UnknownDatetimeFormatException.php Exception if none of the formats matches.
Added simple test.
… be used by Amazon.

Throw UnknownDatetimeFormatException.php Exception if none of the formats matches.
Added simple test.
Copy link
Owner

@jlevers jlevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!!

@jlevers jlevers merged commit ee73b2a into jlevers:main Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants