Python 3 fixes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 2, dict.keys() returned a list but in Python 3 it returns
an opaque iterable type that doesn't directly support indexing.
Fixes this sort of error:
Traceback (most recent call last):
..
File "/home/sam/.local/lib/python3.6/site-packages/lastfmclient/package.py", line 9, in _call
return self._client.call(http_method, method, auth, params)
File "/home/sam/.local/lib/python3.6/site-packages/lastfmclient/client.py", line 76, in call
return self._process_response_data(data)
File "/home/sam/.local/lib/python3.6/site-packages/lastfmclient/client.py", line 131, in _process_response_data
return data[keys[0]]
TypeError: 'dict_keys' object does not support indexing
This type doesn't exist in Python 3.
|
I just spotted https://github.com/jakubroztocil/lastfmclient/pull/1/files which contains the same fixes, plus a lot more stuff. I haven't tested that myself yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This branch fixes a couple of exceptions that I encountered when using lastfmclient with Python3.
I did a brief test using Python2 after my changes. I authenticated and called the
user.get_top_artists()method, which worked as expected.