Add TypeScript Definitions #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edude03
reviewed
Aug 3, 2017
index.d.ts
Outdated
| base?: string; | ||
| intermediatePath?: string; | ||
| strictSSL?: boolean; | ||
| request: Function; |
| /// <reference types="request" /> | ||
| /// <reference types="node" /> | ||
|
|
||
| import * as request from 'request'; |
There was a problem hiding this comment.
Not going to argue this one, but it extends request-promise which I don't think has types anyway
There was a problem hiding this comment.
From request I use only request.CoreOptions and request.RequestResponse: here
And these types are the same for request and request-promise packages
|
Any chance we can get these merged in? Would be nice to have |
|
While we are waiting for this pull request to be accepted, is it possible to get these types published to the definitely typed repo? |
|
@zlepper, that's a good idea. I'll do it this week. |
|
Any update on this, @kopte3 ? |
10 tasks
|
I've created a PR on definitely typed for this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #174