fix build warning when LOG_LEVEL < LOG_INFO_LEVEL #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We cannot do that because this flag is not meant to be used in such way, MQTT_LOG_LEVEL is only for mqtt_log. It is better to do in such way to remove warning and not to not mix definitions: |
|
yes that's another way to do it. independent of LOG setting. I will modify that and push again. |
Compiler generate unused variable 'i' warning in mqtt_list_subscribe_topic when MQTT_LOG_LEVEL < MQTT_LOG_INFO_LEVEL. Signed-off-by: Ajay Bhargav <[email protected]>
SL-RU
approved these changes
Feb 23, 2024
| @@ -1463,6 +1463,8 @@ int mqtt_publish(mqtt_client_t* c, const char* topic_filter, mqtt_message_t* msg | |||
| int mqtt_list_subscribe_topic(mqtt_client_t* c) | |||
| { | |||
| int i = 0; | |||
|
|
|||
| (void) i; /* prevent compiler warning */ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler generate unused variable 'i' warning in mqtt_list_subscribe_topic when MQTT_LOG_LEVEL < MQTT_LOG_INFO_LEVEL.