Replace Twitter by X #1348
Closed
Replace Twitter by X #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jhipster-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I still prefer to call it Twitter.
|
|
I don't think we need to update old release notes |
|
@pascalgrimaud these 4 files or just |
|
Yes I think @qmonmert |
|
@pascalgrimaud I updated with this solution. @mraible WDYT about this? |
|
@qmonmert I don't feel strongly enough about it to approve or deny. ;) |
|
Ok I close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mraible @jdubois @pascalgrimaud @DanielFran are you ok with this update?
I didn't update Twitter logo because the X Twitter is not available with font-awesome 4, we need to upgrade to 6 (with a lot of work).
There are only two logos:
