-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring of generator frontend tests #9833
Restructuring of generator frontend tests #9833
Conversation
murdos
commented
May 18, 2024
- Rename webapp tests folder from src/test/javascript to src/test/webapp :
- So src/main/webapp matches src/test/webapp
- Also frontend tests are not limited to javascript code, this also includes components and e2e tests
- Rename webapp unit tests folder to src/test/webapp/unit
- webapp tests: isolate component tests from e2e tests
- rename e2e folder and remove component tests from e2e folder
ec73a32
to
bf32f80
Compare
Totally agree with this change, although it's a breaking change |
@pascalgrimaud : I'm glad you agree :) I'll try to fix failing test on windows so we can merge it. |
5475582
to
9c3a96c
Compare
FYI: there's an issue with tikui-serve and component tests ran with Cypress on Windows, I'll need to discuss that with @Gnuk when he's available. |
e0c04e8
to
b431724
Compare
@pascalgrimaud : this is now ready for merge (there's no breaking change since it only relates to the internal of the generator) :) With the help of @Gnuk I fixed the windows build. |
can you fix the conflict plz @murdos ? |
So src/main/webapp matches src/test/webapp Also frontend tests are not limited to javascript code, this also includes components and e2e tests
Otherwise, in Tikui serve mode, the first component tests can fail if the Tikui cache doesn't already exist, and because SASS files are transpiled on CSS during test execution
b431724
to
4be8819
Compare
@pascalgrimaud : conflicts are fixed |