WIP: Revisit - Update password reset page to use only react-form capabilities #23147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I certainly support the direction of these code changes, I have a few suggestions. I will write after this. |
hide212131
commented
Aug 12, 2023
|
|
||
| export const PasswordPage = () => { | ||
| const [password, setPassword] = useState(''); | ||
| const [newPassword, setNewPassword] = useState(''); |
There was a problem hiding this comment.
Using React Hooks Form's getValues or useWatch seems more natural.
Comment on lines
+85
to
+86
| labelPlaceholderKey="global.form.currentpassword.label" | ||
| inputPlaceholderKey="global.form.currentpassword.placeholder" |
There was a problem hiding this comment.
I believe the original code label={translate('global.form.newpassword.label')} still works well. The code volume remains roughly the same, and it allows for direct text without using i18n for the label.
| touchedFields={ touchedFields } | ||
| errors={ errors } | ||
| setValue={ setValue } | ||
| nameIdCy="currentPassword" |
There was a problem hiding this comment.
Instead of nameIdCy, the attribute name feels more natural.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR to continue the discussion from #19560
I've made changes to the codes by @Tcharl to incorporate the following features:
Currently, all tests pass when running
npm run e2e.Refer to the following information:
ValidatedTextInput.