Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sonar ratings. #25137

Closed
1 task
mshima opened this issue Feb 9, 2024 · 2 comments · Fixed by #25193
Closed
1 task

Improve sonar ratings. #25137

mshima opened this issue Feb 9, 2024 · 2 comments · Fixed by #25193
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: sonar $300 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@mshima
Copy link
Member

mshima commented Feb 9, 2024

Overview of the feature request

We can improve sonar ratings.
In recent PRs:

  • coverage has increase from 84% to 87%
  • duplications has decrease from 2,5% to 1,8%
  • issues has increased from 66 to 67

Actions:

  • reduce issues by reworking the resource IT.
  • reduce issued by implementing the mapper test.
Motivation for or Use Case
Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@DanielFran DanielFran added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/ labels Feb 9, 2024
@mshima
Copy link
Member Author

mshima commented Feb 9, 2024

I've opened #25153 to discuss 6 sonar issues.

@mshima
Copy link
Member Author

mshima commented Feb 14, 2024

Linked PRs fixed ~45 issues. Will be at 20 with last PR, not every issue was fixed by linked PRs.
Increased coverage by ~4,4%. It's at 91,7%, like as issues, not every gain was done by linked PRs.

We have 6 issues about QueryService, 6 issues about patch implementation #25153, 3 issues about CacheConfiguration file and 5 individual issues.

Suggested fixes:

  • QueryService: Add a Specification Builder at jhipster-framework to simplify the application side.
  • CacheConfiguration: ignore at sonar.properties or use metamodel for jpa.
  • LiquibaseConfig: add a JHipsterProperty for async disabling
  • Commented codes: Move to the generator's README.md and add a link to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: sonar $300 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants