Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero sonar code smells at ng-default #25231

Open
1 task
mshima opened this issue Feb 17, 2024 · 5 comments
Open
1 task

Zero sonar code smells at ng-default #25231

mshima opened this issue Feb 17, 2024 · 5 comments
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: angular theme: java theme: sonar $200 https://www.jhipster.tech/bug-bounties/

Comments

@mshima
Copy link
Member

mshima commented Feb 17, 2024

Overview of the feature request

We have 18 missing code smells now.
We can make it to zero.

Suggested fixes (originally posted at #25137 (comment)):

  • QueryService (6): Add a Specification Builder and functional apis at jhipster-framework to simplify the application side.
  • CacheConfiguration: ignore at sonar.properties or use metamodel for jpa.
  • LiquibaseConfig: add a JHipsterProperty for async disabling
  • Commented codes: drop or move to the generator's README.md and add a link to it.
Motivation for or Use Case
Related issues or PR

#25137

  • Checking this box is mandatory (this is just to show you read everything)
@mshima
Copy link
Member Author

mshima commented Feb 19, 2024

The remaining code smells (6 for jpa model filtering and 6 for patch support #25153) are harder to fix.

@mshima mshima mentioned this issue Feb 26, 2024
6 tasks
@mshima
Copy link
Member Author

mshima commented Feb 26, 2024

New sonar rules. 231 issues now.

@mshima
Copy link
Member Author

mshima commented Feb 28, 2024

We have 110 issues which 98 are false positives.

@DanielFran DanielFran added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Feb 28, 2024
@qmonmert
Copy link
Contributor

qmonmert commented Apr 4, 2024

False positives are fixed.
There are just issues like Refactor this method to reduce its Cognitive Complexity...

@mshima
Copy link
Member Author

mshima commented Apr 5, 2024

Code smells fixed in SonarSource/sonar-html#291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: angular theme: java theme: sonar $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

No branches or pull requests

3 participants