New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit unnecessary classes in HTML tables (#9325) #9376

Draft

ThomasSoeiro wants to merge 3 commits into jgm:main from ThomasSoeiro:table-nonclass

ThomasSoeiro commented Jan 26, 2024

Here is a try for #9325 according to @jgm guidance :

The change in the writer needs to be refined but I guess this is the idea.
I found no use of header/odd/even classes in data/templates/styles.html.
I removed header/odd/even accross the tests; I'm not sure about changes in update test/command/*.md so I put it in a separate commit.

I also found occurence of odd/even in:

pandoc-lua-engine/test/sample.lua and pandoc-lua-engine/test/tables.custom
and /src/Text/Pandoc/Writers/Textile.hs and test/tables.textile

Do they need updating too?

PS: This is my first pull request. It is only WIP but I hope it helps. Otherwise, feel free to close!

ThomasSoeiro added 3 commits

January 24, 2024 20:02


Don't emit unnecessary classes in HTML tables

bc79356


update test/tables/*.html[45]

26ca70d


update test/command/*.md

61d593e

ThomasSoeiro changed the title ~~Table nonclass~~ Don't emit unnecessary classes in HTML tables (#9325)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment