Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three theme options #3531

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliviaBahr
Copy link
Contributor

@oliviaBahr oliviaBahr commented Apr 27, 2024

  • PR Description

    • Make title color options separate from border color options
    • Add option to change title color of selected tabs in inactive views

It's not a super important change I've just always personally thought keeping selected tabs in inactive views highlighted the same color (and just -= AttrBold) looks wrong.
Normal
image
My preference is just bold
image

When I added the change I noticed that changing the border color option also changed the title color and I thought that was unexpected behavior so I added the two other options.

lazygit/docs/Config.md

Lines 56 to 62 in 6390b05

activeTitleColor:
- green
- bold
inactiveTitleColor:
- default
inactiveSelTabTitleColor: # style of 'current tab' title in inactive views
- default # 'default' is activeTitleColor without bold

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

- Make title color options separate from border color options
- Add option to change title color of selected tabs in inactive views
@stefanhaller
Copy link
Collaborator

I'll let @jesseduffield have a look at this, as I'm not personally interested in this change. Hope this doesn't sound offensive, I just need to cut down a bit on the number of things that I get involved in.

(Happy to help with getting the change into gocui though, if Jesse decides we want this.)

@jesseduffield
Copy link
Owner

I will get to this very soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants