Extend icon coverage on remotes and file extensions #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasecilu
force-pushed
the
feat/add_more_icons
branch
from
8bda844
to
72e7428
Compare
|
I used this script to get the asociations from https://github.com/nvim-tree/nvim-web-devicons, before running the script I removed the dots from the file extensions on #!/usr/bin/env bash
go_file="$HOME/git/github/lazygit/pkg/gui/presentation/icons/file_icons.go"
lua_file="$HOME/git/github/nvim-web-devicons/lua/nvim-web-devicons/icons-default.lua"
# Print keys that are missing on lazygit with go formatting
while IFS= read -r line; do
if [[ $line =~ \[\"(.+)\"\] ]]; then
key="${BASH_REMATCH[1]}"
# Search for the key in the Rust file
go_line=$(grep -F "\"$key\"" "$go_file")
if [ -n "$go_line" ]; then
found=1
else
found=0
spaces1=$(printf '%*s' $((19 - ${#key})) "")
echo -en "\t\"$key\":$spaces1{Icon: \"\u"
fi
elif [[ $line =~ " icon = " ]]; then
if [ $found -eq 0 ]; then
glyph=$(echo $line | cut -d \" -f2 | cut -d \" -f1)
unicode_length=$(printf "%04x" "'$glyph" | wc -c)
printf "%04x" "'$glyph"
echo -n '", Color: '
fi
elif [[ $line =~ " color = " ]]; then
continue
elif [[ $line =~ " cterm_color = " ]]; then
if [ $found -eq 0 ]; then
# Extract color
color=$(echo $line | cut -d \" -f2 | cut -d \" -f1)
echo "$color}, // $glyph"
fi
elif [[ $line =~ " name = " ]]; then
continue
fi
done <"$lua_file"Since nvim-tree is a file browser it also have a lot of icon associations for a lot of files like config files, those make sense in a file browser (also in eza) but not much on lazygit... unless someone is sharing their config files on a git repo? (maybe a riced Below I add a list of files and extensions, for the extensions there are a lot I don't know so I didn't included them. Click to toggle visibility of extra associations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I opened #3426 issue, this PR is targeted to fix that.
go generate ./...)docs/Config.md) have been updated if necessaryThis is the result from the remote icons that I posted on the issue.
Note: The FreeBSD only is triggered if the remote is "git.FreeBSD.org", note the capitalization
Edit: btw, there are also icons for gitea ->
nf-linux-gitea, \uf339, and forgejo ->nf-linux-forgejo, \uf335, if someone is interested on some instances that use that sofware.Would be nice if in the future the user can make overrides via config file.
Fix #3426