Add option to specify other shell(Arg) #3299
Conversation
pkg/gui/gui.go
Outdated
| shell := gui.UserConfig.OS.Shell | ||
| if shell != "" { | ||
| osCommand.Platform.Shell = shell | ||
| osCommand.Platform.ShellArg = gui.UserConfig.OS.ShellArg | ||
| } |
There was a problem hiding this comment.
Would it be better to move this logic into NewOsCommand? We want all os commands to inherit that setting, right? Or do we only want the command runner for custom commands to use the shell and shellArgs from the userconfig?
There was a problem hiding this comment.
Sounds good. I don't know how to access config.OS from there, though 😕
There was a problem hiding this comment.
On second thought, I think it would make more sense to pass the OSConfig struct into oscommands.GetPlatform and get that function to extract the shell and shellArg values from there and use them there directly.
Sounds good. I don't know how to access config.OS from there, though 😕
You would be able to access the config through the Common struct that's passed into NewOsCommand function.
There was a problem hiding this comment.
I am not sure, but perhaps an integration test is not the right thing for this feature? Maybe this should just be a unit test in pkg/commands/oscommands/os_test.go
schema/config.json
Outdated
| }, | ||
| "shell": { | ||
| "type": "string", | ||
| "description": "Shell and ShellArg are the shell and corresponding argument to be used for executing custom commands.\nSee https://github.com/jesseduffield/lazygit/blob/master/docs/Config.md#custom-command-for-copying-to-clipboard" |
There was a problem hiding this comment.
The URL here needs to point to the "Custom Shell for executing arbitrary commands" section of the Config.md file.
| if osConfig.Shell != "" { | ||
| platform.Shell = osConfig.Shell | ||
| platform.ShellArg = osConfig.ShellArg | ||
| } |
There was a problem hiding this comment.
I think at this point, we should probably just consider setting bash and -c as default parameters for Shell and ShellArg in the user_config file. That way, we can just directly take the values from osConfig and use them in the Platform literal.
PR Description
if
os.shellis not empty it replaces the default"bash"shell andos.shellArgreplaces the default"-c"argument.started writing test but don't know how to check stdout or command log.
Please check if the PR fulfills these requirements
go generate ./...)docs/Config.md) have been updated if necessary