Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commitPrefix for defining a prefix for any project #3291

Merged
merged 1 commit into from May 1, 2024

Conversation

duckbrain
Copy link
Contributor

  • PR Description

Adds a new option git.comitPrefix to act similarly to git.commitPrefixes, except, if defined, it applies to any repo that doesn't have an entry in git.commitPrefixes.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@duckbrain
Copy link
Contributor Author

See:

#2759
#1941

@stefanhaller
Copy link
Collaborator

Makes sense to me. (I haven't looked at the code yet, though.)

As a followup I propose to support per-repo config files (see #3293) and get rid of the commitPrefixes option.

@duckbrain
Copy link
Contributor Author

As a followup I propose to support per-repo config files (see #3293) and get rid of the commitPrefixes option.

Was this an ask for this PR or future plans? I had been understanding the latter. I agree that's a sensible way to move forward, but it seems out of scope to do that all at once.

@stefanhaller
Copy link
Collaborator

No, not for this one. Is "followup" not a commonly used term in software development? At work we use it for things that we will do in a separate PR later.

One of these days I'll actually get around to reviewing this PR, sorry that it fell through the cracks. Feel free to ping earlier when a PR doesn't get reviewed!

@stefanhaller stefanhaller added the enhancement New feature or request label May 1, 2024
@stefanhaller
Copy link
Collaborator

Looks good, great work. I took the liberty to squash all commits into one, I think it makes sense in this case. Also rebased on master in order to be able to merge.

Sorry again for the long delay in reviewing this.

@stefanhaller stefanhaller merged commit 618fe53 into jesseduffield:master May 1, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants