Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#291: Adding ignore_hierarchy option to rule if_030 #788

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Issue#291: Adding ignore_hierarchy option to rule if_030 #788

wants to merge 21 commits into from

Conversation

jeremiah-c-leary
Copy link
Owner

Adding ignore_hierarchy option to rule if_030.

  1. Added test
  2. Added rule

Resolves #291

@jeremiah-c-leary
Updates for issue #291
3e7fa3e 
Adding ignore_hierarchy option to rule if_030.

  1)  Added test
  2)  Added rule
@codecov
Copy link

codecov bot commented May 25, 2022 •
edited

Codecov Report

Base: 95.75% // Head: 95.70% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (b5918f5) compared to base (ec228bb).
Patch coverage: 92.97% of modified lines in pull request are covered.

❗ Current head b5918f5 differs from pull request most recent head 9c0f84e. Consider uploading reports for the commit 9c0f84e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   95.75%   95.70%   -0.05%     
==========================================
  Files        1373     1375       +2     
  Lines       25658    25781     +123     
==========================================
+ Hits        24568    24673     +105     
- Misses       1090     1108      +18
Impacted Files Coverage Δ
vsg/vhdlFile/extract/get_line_number.py 30.76% <30.76%> (ø)
vsg/vhdlFile/extract/tokens.py 88.33% <75.00%> (-2.06%) ⬇️
vsg/vhdlFile/vhdlFile.py 89.87% <87.50%> (-0.24%) ⬇️
...g/rules/blank_line_below_line_ending_with_token.py 98.86% <98.18%> (-1.14%) ⬇️
vsg/rules/if_statement/rule_030.py 100.00% <100.00%> (ø)
...essive_blank_lines_below_line_ending_with_token.py 95.74% <100.00%> (ø)
vsg/vhdlFile/extract/__init__.py 100.00% <100.00%> (ø)
...ct/get_blank_lines_below_line_ending_with_token.py 81.25% <100.00%> (-18.75%) ⬇️
...e/extract/get_line_below_line_ending_with_token.py 100.00% <100.00%> (ø)
...ine_below_line_ending_with_token_with_hierarchy.py 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeremiah-c-leary
Added allow_end_ifs option
8b8351b 
  1)  Added test
  2)  Added option
@jeremiah-c-leary
Adding allow_end_process option
4fb70c6 
  1)  Added test
  2)  Added option
@jeremiah-c-leary
Added except_end_case option.
b60711b 
Fixed misreporting of line number in several rules.
@jeremiah-c-leary
Refactoring to improve code flow.
9d0135d
@jeremiah-c-leary
Adding except_end_loop option
f3d0a41 
  1) Added test
  2) Added option
@jeremiah-c-leary
Adding except_end_subprogram_body option
5e9b51e 
  1)  Added test
  2)  Added option
@jeremiah-c-leary
Adding all true test.
5fe2784
@jeremiah-c-leary
Adding except_end_if to no_blank_line option.
f23b4a9
@jeremiah-c-leary
Refactoring to improve readability.
1c0cccc
@jeremiah-c-leary
Refacotring to improve readability.
80d6c02
@jeremiah-c-leary
Refacoring to remove complexity.
cdccc5f
@jeremiah-c-leary
Minor formatting updates.
4d69e2b
@jeremiah-c-leary
Refactoring to reduce number of arguments in functions.
6f1e5e4
@jeremiah-c-leary
Moving function set_token_hierarchy to its own file.
c67ae66
@jeremiah-c-leary
Refactoring to improve readability.
48d1318
@jeremiah-c-leary
Refactoring to improve readability.
c6cccd2
@jeremiah-c-leary
Minor formatting updates.
68a5b62
@jeremiah-c-leary
Minor formatting update.
a68fb66
@jeremiah-c-leary
Refactored _get_tokens_of_interest to reduce complexity.
b5918f5
@jeremiah-c-leary
Updating rule if_031 to allow exception of if statements in previous …
9c0f84e 
…lines.
@jeremiah-c-leary jeremiah-c-leary changed the title Updates for issue #291 Issue#291: Adding ignore_hierarchy option to rule if_030 Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blank line before if and after end if.
1 participant
@jeremiah-c-leary