client/ClientHelper.java: fix check for p4 error message when there are multiple files to reconcile

[austin987]

Original patch by Akos Bannerth

Closes: https://issues.jenkins.io/browse/JENKINS-72335

When using p4publish with multiple paths listed in the paths argument, and the workspace doesn't contain any changes compared to the depot, publish will fail with

Unable to publish workspace: hudson.AbortException: P4JAVA: Error(s):
No file(s) to reconcile.

This seems to be a result of a check in ClientHelper.java

getValidate().check(status, "- no file(s) to reconcile", "instead of", "empty, assuming text", "also opened by");

which apparently should ignore the p4java status "- no file(s) to reconcile" but when reconciling with multiple paths, the message is "No file(s) to reconcile." - this can be easily tested from the command line:

> p4 rec foo/...
foo/... - no file(s) to reconcile.
> p4 rec foo/... bar/...
No file(s) to reconcile.

The attached patch changes the ignore string so that it's recognized in both cases, as the check uses StringUtils.containsIgnoreCase(msg, istring) to compare the message with it.

Testing done

Built plugin and tested change on a staging server.

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

[austin987]

If possible, please tag a release after this is merged, thanks!

[austin987]

Hi, is there anything I can do to improve this patch?

[jg-outerdawn]

This issue is also blocking our build pipeline, would be really nice to get it fixed.