[JENKINS-73090] Handle CR from LineTransformationOutputStream
#9219
+79
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-73090 for background.
Testing done
Without the fix, the
cr
test with the count set to a billion failed with(I am not leaving this count that high in the committed test since when it passes it takes over two minutes of high CPU on my laptop.)
I also tried installing the Timestamper plugin, enabling the global decorator (auto timestamps in all Pipeline builds), and running the Windows
git clone
pipeline mentioned in Jira. This produced timestamped output, though the output did seem to come all at once, though that seemed to be an aspect of Git not Jenkins so far as I could tell from looking at thejenkins.log
file in the workspace temp dir; so I also triedwhich did produce live timestamped output, though the classic console does not reliably show it; Pipeline Graph View plugin does. (
tail -f …/builds/…/log
from a terminal actually updates the line in place.)Proposed changelog entries
Proposed upgrade guidelines
N/A
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).