Adds support of sessionId for External-Job-Monitor #8825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using the External-Job-Monitor plugin and following this Doc, but I was getting 403 responses like this:
On looking into the code, found a bug:
GET request to fetch
crumb
before POST request forpostBuildResult
has an extra'
, due to which GET request was giving a non-2XX response, and crumb fields were not getting enriched.Furthermore, I was still getting 403 responses, and then I found this change. which mentioned:
So, to make things work, I added the support for
sessionId
returned in the GET call (to fetch crumb) to be sent in the POST call forpostBuildResult
.And then getting the expected results:
To summarize, this PR has the following two changes:
Testing done
Testing is done as mentioned above.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).