[JENKINS-72622] Address SpotBugs warning

jenkinsci · May 15, 2024 · 222df09 · 222df09
1 parent 4167549
commit 222df09
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/core/src/main/java/jenkins/agents/CloudSet.java b/core/src/main/java/jenkins/agents/CloudSet.java
@@ -244,7 +244,11 @@ private void handleNewCloudPage(Descriptor<Cloud> descriptor, String name, Stapl
  public synchronized void doDoCreate(StaplerRequest req, StaplerResponse rsp,
  @QueryParameter String cloudDescriptorName) throws IOException, ServletException, Descriptor.FormException {
  Jenkins.get().checkPermission(Jenkins.ADMINISTER);
- Cloud cloud = Cloud.all().findByName(cloudDescriptorName).newInstance(req, req.getSubmittedForm());
+ Descriptor<Cloud> cloudDescriptor = Cloud.all().findByName(cloudDescriptorName);
+ if (cloudDescriptor == null) {
+ throw new Failure(String.format("No cloud type ‘%s’ is known", cloudDescriptorName));
+ }
+ Cloud cloud = cloudDescriptor.newInstance(req, req.getSubmittedForm());
  if (!Jenkins.get().clouds.add(cloud)) {
  LOGGER.log(Level.WARNING, () -> "Creating duplicate cloud name " + cloud.name + ". Plugin " + Jenkins.get().getPluginManager().whichPlugin(cloud.getClass()) + " should be updated to support user provided name.");
  }