PoC: Install Java if not installed in the agent #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/Home.md
Outdated
| @@ -110,3 +110,8 @@ Instance configurations have many options that were not listed above. A few of t | |||
| access from metadata. For more info, review the service account documentation. | |||
|
|
|||
|
|
|||
| # Install java if not found | |||
|
|
|||
| By default the agents do require to have java installed, this particular flag feature will enable to install java before the provisioning happens. | |||
There was a problem hiding this comment.
s/do require/are required
s/java/Java
docs/Home.md
Outdated
|
|
||
| By default the agents do require to have java installed, this particular flag feature will enable to install java before the provisioning happens. | ||
|
|
||
| If you want to turn on this installation strategy then you set SystemProperty `com.google.jenkins.plugins.computeengine.enableJavaInstallation=true` |
There was a problem hiding this comment.
Please be sure to mention the UI based configuration as well.
There was a problem hiding this comment.
UI was not configured for this particular use case, although I just replace it with the UI approach
| return; | ||
| if (ENABLE_JAVA_INSTALLATION) { | ||
| logInfo(computer, listener, "Let's install java for some *nix flavours"); | ||
| if (!installJava(computer, conn, logger, listener, "sudo yum install -y java-1.8.0-openjdk.x86_64")) { |
There was a problem hiding this comment.
I wonder if there might not be a Chocolatey/PS analog for Windows we could employ.
There was a problem hiding this comment.
I think so, let's see how it goes with the upcoming iterations first. I'll include a task in this PR to see whether we can support windows too.
|
Thanks @v1v |
v1v
force-pushed
the
feature/jdk-auto-installer
branch
from
88c1614
to
1c8c66d
Compare
|
@craigdbarber , regarding the |
|
@v1v Here are the logs from maven from on the test that failed: Here is the failsafe report output from that test: |
|
Actually @v1v, build 5 from our tests succeeded, but for whatever reason failed with the core jenkins build on Java 11. It doesn't make sense why, so I think it may succeed if reran. The easiest way to trigger that is probably to amend the latest commit and force push. |
|
I also noticed that none of the Google-provided free Linux images install a JRE by default. I settled on using Packer to publish an image to my own project: packer {
required_plugins {
googlecompute = {
version = ">= 1.1.1"
source = "github.com/hashicorp/googlecompute"
}
}
}
variable "project" {
type = string
}
variable "zone" {
type = string
}
source "googlecompute" "base" {
project_id = var.project
zone = var.zone
source_image_project_id = ["centos-cloud"]
source_image_family = "centos-stream-9"
ssh_username = "jenkins"
}
build {
sources = ["sources.googlecompute.base"]
provisioner "shell" {
inline = ["sudo dnf --assumeyes install java-11-openjdk-headless && java -version"]
}
}A feature like in this PR might be useful for experimentation but you should not use it in production—it would be too slow, and put too much load on Linux distribution package servers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PoC to allow using the agents that are already provided in the default projects without any need to customise the Java installation in the default images for the default projects.
google-compute-engine-plugin/src/main/java/com/google/jenkins/plugins/computeengine/InstanceConfiguration.java
Lines 101 to 116 in 2e04739
A similar approach was implemented with the EC2-plugin:
Screenshots
Actions
Manual tests
I did run some tests in one of my instances:
-ythenthe global logs said something like the below:
and the logs in the agent said the below
-ythen:Questions
A kind of similar approach can be accomplished with the Startup Script, see ->
google-compute-engine-plugin/src/test/resources/com/google/jenkins/plugins/computeengine/integration/configuration-as-code-it.yml
Line 26 in 2e04739
Do we want to enable this feature and also the script in charge of the installation? In other words, similar to the startup script but without the ssh stop/start. What do you think?
Related issues