Adding VectorCAST coverage

[TimSVector]

Adding MC/DC, Function, and Function Call coverage. Results being shown in the coverage report and associated graphs. Method coverage not working for some reason.

Testing done

Tested with an expanded Cobertura xml file. Run through multiple configurations on Jenkins server with varying coverage configurations

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Open a fork of the repository

   Open a fork of the repository
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

[TimSVector]

Not sure how to fix this the missing comma affer "id" : "error-prone"

Quality Monitor PR / Build, test and monitor quality on Ubuntu (pull_request_target) Failing after 3m

"tools": [
  {
    "id": "spotbugs",
    "sourcePath": "src/main/java",
    "pattern": "**/target/spotbugsXml.xml"
  },
  {
    "id": "error-prone"
    "pattern": "**/maven.log"
  }

[TimSVector]

Not sure how to fix this the missing comma affer "id" : "error-prone"

Quality Monitor PR / Build, test and monitor quality on Ubuntu (pull_request_target) Failing after 3m

"tools": [
  {
    "id": "spotbugs",
    "sourcePath": "src/main/java",
    "pattern": "**/target/spotbugsXml.xml"
  },
  {
    "id": "error-prone"
    "pattern": "**/maven.log"
  }

@uhafner - do you know how to clear this error? I don't know what I've done in the branch to create it. I'd like to move on to the task of fixing the coverage-plugin changes that are pending this artifact

[uhafner]

I think I fixed that in main.

[uhafner]

It seems that you did commit your changes in main. This is not ideal. You should always create changes in a separate branch. Then it is much easier to update from the upstream repository.

[TimSVector]

I thought you requested a fork and a PR. I can redo if you’d like.

…

________________________________ From: Ullrich Hafner ***@***.***> Sent: Thursday, May 16, 2024 12:40:02 PM To: jenkinsci/coverage-model ***@***.***> Cc: Schneider, Tim ***@***.***>; Author ***@***.***> Subject: Re: [jenkinsci/coverage-model] Adding VectorCAST coverage (PR #105) You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> It seems that you did commit your changes in main. This is not ideal. You should always create changes in a separate branch. Then it is much easier to update from the upstream repository. — Reply to this email directly, view it on GitHub<#105 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AENYLQ4P7CDAVYVXFBEIID3ZCTOOFAVCNFSM6AAAAABHL3FGSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVG4ZTEMBQGY>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[uhafner]

I thought you requested a fork and a PR. I can redo if you’d like.

No, a fork is correct. You just never use the main branch even in your fork. Otherwise you cannot keep your forked main branch in sync with the main branch of the upstream, see https://gist.github.com/Chaser324/ce0505fbed06b947d962

You see the effect of not creating a branch now in the diff: https://github.com/jenkinsci/coverage-model/pull/105/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

Now there are many unrelated changes visible...

[uhafner]

Thanks for this pull request, everything is well written and tested!

The only bigger thing is the additional FUNCTION metric. I would be very happy if we can achieve the same results with the existing METHOD metric.

[uhafner]

Thanks for fixing all those tasks! The only thing I would like to change is the duplicate enum FUNCTION vs. METHOD. Do you think that we can eliminate it? I think I almost got rid of it a couple of weeks ago but then dropped my changes... If you need help, I can push a draft of these changes again...

[TimSVector]

Thanks for fixing all those tasks! The only thing I would like to change is the duplicate enum FUNCTION vs. METHOD. Do you think that we can eliminate it? I think I almost got rid of it a couple of weeks ago but then dropped my changes... If you need help, I can push a draft of these changes again...

Please push any suggested changes for this. I cannot figure it out. I think what's tripping me up is Method depends on Children and Function is a Value (2/4 50%)

    FUNCTION(new ValuesAggregator()),
    METHOD(new LocOfChildrenEvaluator()),

[uhafner]

Yes, this exactly was the problem. I fixed that code now. When a local value is present, then we do not need to derive the "container" metrics from the line coverage.

I pushed my changes here: d9a047c

If you prefer, I can push the changes back to your repo?