Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Aggregate/Summary Widget of Successful Builds #336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sophiebr
Copy link

- Adds acceptance tests
- Provides configuration option

    - Adds acceptance tests
    - Provides configuration option
@sophiebr
Copy link
Author

Added a "Collapse Successful Builds" option in the view configuration. When applied, all successful builds are collapsed into a single summary widget.

  • If all builds are successful, a full screen summary widget is displayed.
  • If not, a summary widget of any succeeding builds is displayed at the bottom of the view. All remaining non-successful builds are displayed in the usual manner.

Acceptance tests also added to make sure this feature works as expected.

Includes screenshots
@jan-molak
Copy link
Member

Hey @sophiebr, thanks, this looks really cool! I'll review your PR shortly

@NeverOddOrEven
Copy link

There are some scaling issues we identified when the collapse option is ticked. I will try to fix that issue. Also, I would like to update the styling so that non-successful badges and the summary badge never "touch."

@ghost
Copy link

ghost commented Oct 30, 2018

Currently we're looking for a way to hide successful builds. This looks promising 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants