Skip to content

Commit

Permalink
Forward compatibility for build history widget rewrite (#1557)
Browse files Browse the repository at this point in the history
Co-authored-by: Tim Jacomb <[email protected]>
  • Loading branch information
janfaracik and timja committed May 22, 2024
1 parent 7da8433 commit 4bc4e3b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/test/java/plugins/DescriptionSetterPluginTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ public void set_build_description_based_upon_build_log_file() {
assertThat(find(by.css("div#description div")).getText(), is(equalTo(msg)));

j.open();
assertThat(find(by.css("#buildHistory .desc")).getText(), is(equalTo(msg)));
assertThat(find(by.css("#buildHistoryPage .desc, #buildHistoryPage .app-builds-container__item__description")).getText(), is(equalTo(msg)));
}
}
6 changes: 3 additions & 3 deletions src/test/java/plugins/NodeLabelParameterPluginTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ public boolean matchesSafely(Build build) {
private org.hamcrest.Matcher<String> isPending(String nodename) {
return allOf(
containsString("Job triggered without a valid online node, given where: " + nodename),
containsString("pending")
containsStringIgnoringCase("Pending")
);
}

Expand All @@ -524,8 +524,8 @@ private String getPendingBuildText(Build build) {
build.job.open();

// pending message comes from the queue, and queue's maintenance is asynchronous to UI threads.
// so if the original response doesn't contain it, we have to wait for the refersh of the build history.
// so if the original response doesn't contain it, we have to wait for the refresh of the build history.
// so give it a bigger wait.
return find(by.css("#buildHistory")).getText();
return find(by.css("#buildHistoryPage")).getText();
}
}

0 comments on commit 4bc4e3b

Please sign in to comment.