Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve DNS hostnames from within pod in minikube #3609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PaulRepo
Copy link

More info on this can be found at this slack chat

Description

with recent upgrade of alpine linux in image ghcr.io/jenkins-x/jx-boot:3.2.338, minikube boot pod and pipelines are failing with error as Could not resolve host: github.com

Fixes # (issue)
Need to add custom dnspolicy to boot and pipeline pods.

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jenkins-x-bot
Copy link
Contributor

Hi @PaulRepo. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign babadofar
You can assign the PR to them by writing /assign @babadofar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PaulRepo
Copy link
Author

/assign @ankitm123

With the recent upgrade of base image of ghcr.io/jenkins-x/jx-boot:3.2.338 to alpine linux v3.15 in some of the local providers like minikube, the pod's DNS nameserver is not able to resolve DNS hostname outside k8s cluster like github.com.

To resolve this issue you need to add [custom dnspolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy) on your local cluster repository in below files with this change
```yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to change the dns settings in the minikube cluster itself?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is possible and even I have raised a corresponding PR . But it will be specific to minikube and as you pointed out before, these changes cannot be merged to the jenkins-x versionStream repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant if you can change it when creating the minikube cluster (before running jx admin operator and running the boot job).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With further testing, I found some more bugs and above solution is not enough. I'll work upon it in my free time. As of now please do not merge this PR.

@ankitm123
Copy link
Member

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants