Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add github api value for conflict #445

Merged
merged 1 commit into from
May 17, 2024
Merged

fix: add github api value for conflict #445

merged 1 commit into from
May 17, 2024

Conversation

msvticket
Copy link
Member

This method is used to in (among others) the code for GitHub when interpreting the value of mergeable_state as returned by the rest API. But it seems like the code is based on the possible values of the field MergeableState in the GraphQL API. But based on the community discussions listed below the possible values are actually the ones listed for MergeStateStatus in the GraphQL API.

https://github.com/orgs/community/discussions/24299#discussioncomment-3243704
https://github.com/orgs/community/discussions/21886

@jenkins-x-bot
Copy link

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@garethjevans
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit ded4738 into main May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants