Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user configuration of player menu background and fade out #3592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Draegert
Copy link

@Draegert Draegert commented May 20, 2024

Added support for user configuration of player menu background colors.
This allows the user to select between background colors (transparent, light (default), and dark) in the playback settings under the new 'Player menu'-section.
The player menu is shown when a video is paused i.a. and always has slight darkening of the video, until now.

Added support for user configuration of player menu fade out timer.
This allows the user to set the fade out timer (between 0 and 6 seconds) in the playback settings under the new 'Player menu'-section.
The player menu takes 6 seconds to fade out after a video is resumed, until now, where the user can adjust the timer as they desire. By setting the timer to 0, the play menu won't show when using skips but still when you pause.

I found these behaviours bothersome, so I fixed it and now share the result.

Keep up the good work. It's much appreciated.

Administrator and others added 2 commits May 20, 2024 17:51
@Draegert Draegert changed the title Added support for user configuration of player menu settings Add support for user configuration of player menu settings May 20, 2024
@Draegert Draegert changed the title Add support for user configuration of player menu settings Add user configuration of player menu background and fade out May 20, 2024
@nielsvanvelzen
Copy link
Member

I'm not a fan of introducing options for everything the app can do. In my opinion we should make sure we have sane defaults.

Changing the overlay hide timer to a different value is fine, but not with an option. Just change the value. What would your preference be here?

The option to change the background color I don't really understand. Why would you want that?

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Conflicts prevent merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants