Fix 4k HEVC downscaling on 1080p devices

[MichaelRUSF]

Changes
Add DeviceUtils.has4kVideoSupport conditional tests directly to the deviceHevcCodecProfile in the ProfileHelper.

Issues
Fixes #3388 #2516

[lawadr]

What do these conditions add? The max1080pProfileConditions are already included in a CodecProfile to limit the resolution. Including them here too should be pointless noise.

See:

jellyfin-androidtv/app/src/main/java/org/jellyfin/androidtv/util/profile/ExoPlayerProfile.kt

Lines 202 to 208 in 5674a93

	// Limit video resolution support for older devices
	if (!DeviceUtils.has4kVideoSupport()) {
	add(CodecProfile().apply {
	type = CodecType.Video
	conditions = max1080pProfileConditions
	})
	}

The way the Jellyfin server works is that all codec profiles that match the type, codec, container and applyConditions of a media file need all their conditions to be true in order for compatibility to be agreed. Therefore the width and height are already being checked for when DeviceUtils.has4kVideoSupport() is false due to the above.

[MichaelRUSF]

In theory, that statement should work, but it doesn't. Why not? Go figure. Luckily, I was able to dig up some old 1080p devices to test this out. I tried several different ways of rewriting this, but this is the version that actually worked.

I can tell you some findings with the original code. A 4k video would transcode initially for unsupported resolution as it should. Play another video then come back and the same file would no longer transcode and would just get remuxed causing the player to crash, along with any other video played after that. 🤷‍♂️

[nielsvanvelzen]

If the profile is correct the bug should be fixed server-side