Dim static elements in screensaver #3368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abjorck
force-pushed
the
Disable_static_elements_on_screensaver
branch
from
8d4157e
to
fa37f5a
Compare
nielsvanvelzen
requested changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to "reopen" pull #2566 to dim the white static elements on the screensaver
Changes
Set alpha on logo, clock, and content title.
I also did a miniscule change to the fade since I think the snap-out was sometimes off and gave a janky feeling when the old image disappeared, not sure why, maybe a frame timing thing. Seems hard to record and report but I can try making it a seperate issue if you dont want it here
Issues