Fix Unit tests failing due to culture differences #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source generators must use NetStandard 2.0 as per documentation. Having .NET 6 and .NetStandard 2.1 included has been causing VS2022 to load the wrong version and not run the source generator properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of the Unit tests have been failing on my system straight out of the box, without making any modifications to the library.
I have found that this is due to the system culture being simply assumed to be English / US in some places, but my system culture is actually Czech, so some numbers/things parse/format differently.
This PR fixes those unit tests to respect the provided culture information, rather than just assuming, which makes all the tests fail on my system.