chore(lib): fully refactor the library for v3 #117
Conversation
|
Thank you for updating CHANGELOG.md! Always feel free to edit it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
src/check.rs|861 col 4| If ‘Type’ is a classification term, ‘a’ is not necessary. Use “Type of”. (The phrases ‘kind of’ and ‘sort of’ are informal if they mean ‘to some extent’.) (KIND_OF_A[1])
Suggestions: Type of
Rule: https://community.languagetool.org/rule/show/KIND_OF_A?lang=en-US&subId=1
Category: GRAMMAR
src/check.rs|884 col 38| Possible agreement error - use third-person verb forms for singular and mass nouns. (MASS_AGREEMENT[11])
Suggestions: starts
Rule: https://community.languagetool.org/rule/show/MASS_AGREEMENT?lang=en-US&subId=11
Category: GRAMMAR
src/check.rs|993 col 20| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
src/check.rs|1017 col 20| Two consecutive dots (DOUBLE_PUNCTUATION)
Suggestions: ., …
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-periods
Rule: https://community.languagetool.org/rule/show/DOUBLE_PUNCTUATION?lang=en-US
Category: PUNCTUATION
src/check.rs|1121 col 13| If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Response, response
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
src/check.rs|1174 col 18| Two consecutive dots (DOUBLE_PUNCTUATION)
Suggestions: ., …
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-periods
Rule: https://community.languagetool.org/rule/show/DOUBLE_PUNCTUATION?lang=en-US
Category: PUNCTUATION
src/check.rs|1189 col 13| If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Offset, offset
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| [#6](https://github.com/jeertmans/languagetool-rust/pull/6) | ||
| - Add compare links to release tags in CHANGELOG. | ||
| [#9](https://github.com/jeertmans/languagetool-rust/pull/9) | ||
| - Add action to check if can publish. |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
It seems that a pronoun is missing. (IF_VB[1])
Suggestions: if you, if I, if it, if we
Rule: https://community.languagetool.org/rule/show/IF_VB?lang=en-US&subId=1
Category: GRAMMAR
| /// | ||
| /// The input can be one of the following: | ||
| /// | ||
| /// - raw text, if `--text TEXT` is provided; |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: text
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
| fn default() -> Self { | ||
| Self { | ||
| hostname: "https://api.languagetoolplus.com".to_string(), | ||
| ..Default::default() |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Two consecutive dots (DOUBLE_PUNCTUATION)
Suggestions: ., …
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-periods
Rule: https://community.languagetool.org/rule/show/DOUBLE_PUNCTUATION?lang=en-US
Category: PUNCTUATION
| } | ||
|
|
||
| impl Client { | ||
| /// Construct a HTTP url base on the current hostname, optional port, |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’. (EN_A_VS_AN)
Suggestions: an
URL: https://languagetool.org/insights/post/indefinite-articles/
Rule: https://community.languagetool.org/rule/show/EN_A_VS_AN?lang=en-US
Category: MISC
| #[inline] | ||
| pub fn url(&self, endpoint: &str) -> String { | ||
| let hostname = self.hostname; | ||
| match self.port { |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Port, port
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| #[derive(Clone, Debug, Deserialize, PartialEq, Eq, Serialize)] | ||
| #[non_exhaustive] | ||
| pub struct Category { | ||
| /// Category id. |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| #[non_exhaustive] | ||
| pub struct Category { | ||
| /// Category id. | ||
| pub id: String, |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| pub category: Category, | ||
| /// Rule description. | ||
| pub description: String, | ||
| /// Rule id. |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| /// Rule description. | ||
| pub description: String, | ||
| /// Rule id. | ||
| pub id: String, |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| /// Issue type. | ||
| pub issue_type: String, | ||
| /// Rule source file. | ||
| /// Rule sub id. |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
No description provided.